[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218212#comment-14218212
 ] 

Hudson commented on BOOKKEEPER-797:
-----------------------------------

SUCCESS: Integrated in bookkeeper-trunk #855 (See 
[https://builds.apache.org/job/bookkeeper-trunk/855/])
BOOKKEEPER-797: IllegalArgumentException when calling 
CodahaleOpStatsLogger#toOpStatsData() (ivank: rev 1640597)
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* 
/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/pom.xml
* 
/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleOpStatsLogger.java
* 
/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/test
* 
/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/test/java
* 
/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/test/java/org
* 
/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/test/java/org/apache
* 
/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/test/java/org/apache/bookkeeper
* 
/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/test/java/org/apache/bookkeeper/stats
* 
/zookeeper/bookkeeper/trunk/bookkeeper-stats-providers/codahale-metrics-provider/src/test/java/org/apache/bookkeeper/stats/CodahaleOpStatsTest.java


> IllegalArgumentException when calling CodahaleOpStatsLogger#toOpStatsData()
> ---------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-797
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-797
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-stats
>    Affects Versions: 4.3.0
>            Reporter: Matthieu Morel
>            Assignee: Matthieu Morel
>            Priority: Minor
>             Fix For: 4.4.0
>
>         Attachments: codahale-stats-opstats-fix.patch, 
> codahale-stats-opstats-fix.patch
>
>
> The implementation of CodahaleOpStatsLogger#toOpStatsData() passes incorrect 
> parameters to codahale's Snapshot#getValue method, resulting in the following 
> runtime exception:
> java.lang.IllegalArgumentException: 10.0 is not in [0..1]
>       at com.codahale.metrics.Snapshot.getValue(Snapshot.java:52)
>       at 
> org.apache.bookkeeper.stats.CodahaleOpStatsLogger.toOpStatsData(CodahaleOpStatsLogger.java:64)
> ...
> In order to pass quantiles as [0..1] values, as expected by codahale metrics 
> library, we must divide parameters by 100 before passing them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to