At 12:56 AM 02/20/2002, Peter R. Wood wrote:
>Hi all,
>
>Thanks for the C&C on my regex. I will definitely avoid the
>tentpole syndrome in the future, as well as add the option of having
>no spaces around the hint words (although I need to check to see if
>this condition *should* be allowed on Oracle's end), and removing
>some greediness in looking for the hint keywords themselves. Here is
>a revised version:
>
>if ( $query =~ m#/\*\+\s+?(+*?)\s+?\*# ) {
You've revised it too much here. You have (+*?) when you should have
either (.*?) or (.+?), probably the latter, and you lost your
trailing /.
--
Greg Marr
[EMAIL PROTECTED]
"We thought you were dead."
"I was, but I'm better now." - Sheridan, "The Summoning"
