On Apr 3, 2012, at 12:17 AM, phoenix wrote: > I have finished the patch on three functions: rt_ell_brep(), rt_ehy_brep() > and rt_hyp_brep(). Rotation and translation matrices are applied so that it > can deal with all primitives of that kind. They are together in one patch. > See > http://sourceforge.net/tracker/?func=detail&aid=3513288&group_id=105292&atid=640804 > Lots of advises and suggestions are welcomed.
Nice work and thanks for breaking out the separate conversions into separate patch files so they're easier to review independently. The only thing I noticed right away is that the indentation is wrong (I believe your editor is injecting literal tabs). The include/ws.sh and include/indent.sh (or M-x indent-region in Emacs) might help. Otherwise, nice example of a patches relevant to the task you're interested in working on. Cheers! Sean ------------------------------------------------------------------------------ Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
