On Jun 14, 2012, at 8:03 PM, plussai wrote: > In function of SurfaceTree::subdivideSurface() at > src/opennurbs_exp.cpp,line 1528 to 1531: > const ON_Surface* surf = m_face->SurfaceOf(); > localsurf->FrameAt(u.Mid() - uq, v.Mid() - vq, frames[5]); > localsurf->FrameAt(u.Mid() - uq, v.Mid() + vq, frames[6]); > localsurf->FrameAt(u.Mid() + uq, v.Mid() - vq, frames[7]); > localsurf->FrameAt(u.Mid() + uq, v.Mid() + vq, frames[8]); > As I know the Interval u,v is in gloable area, So I think the four lines > above need to be modified as: > surf->FrameAt(u.Mid() - uq, v.Mid() - vq, frames[5]); > surf->FrameAt(u.Mid() - uq, v.Mid() + vq, frames[6]); > surf->FrameAt(u.Mid() + uq, v.Mid() - vq, frames[7]); > surf->FrameAt(u.Mid() + uq, v.Mid() + vq, frames[8]); > I'm not so convinced about it.Are there someone can check it?
Interesting. At a glance, I'm not sure about that one myself given the similar framing in SurfaceTree::subdivideSurfaceByKnots(). There are so many changes in that commit that it's not obvious whether it's intended or some copy-paste mistake. The localsurf size is immediately used after framing, which would lead me to think it was intentional; and maybe SurfaceTree::subdivideSurfaceByKnots() is questionable. The change was from r41485: http://brlcad.svn.sourceforge.net/viewvc/brlcad?view=revision&revision=41485 Undoubtedly best inspected by Keith or worth testing. Cheers! Sean ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
