Hi Laijiren,
No. The u,v are recursively passed to subdivideSurface() along with the subdivided surface 'localsurf'. So the original code needs to stay. The local variable "surf" and the following code at the beginning of the function:
const ON_Surface* surf = m_face->SurfaceOf();
const ON_Surface* surf = m_face->SurfaceOf();
ON_Interval usurf = surf->Domain(0);
ON_Interval vsurf = surf->Domain(1);
was probably left in from a debugging session and are not used be the function. If anything these three lines of code can be removed.
Thanks for pointing that out and sorry for the confusion.
-Indianlarry
On 06/14/12, plussai<[email protected]> wrote:ON_Interval vsurf = surf->Domain(1);
was probably left in from a debugging session and are not used be the function. If anything these three lines of code can be removed.
Thanks for pointing that out and sorry for the confusion.
-Indianlarry
Hi!
In function of SurfaceTree::subdivideSurface() at src/opennurbs_exp.cpp,line 1528 to 1531:
const ON_Surface* surf = m_face->SurfaceOf();
localsurf->FrameAt(u.Mid() - uq, v.Mid() - vq, frames[5]);
localsurf->FrameAt(u.Mid() - uq, v.Mid() + vq, frames[6]);
localsurf->FrameAt(u.Mid() + uq, v.Mid() - vq, frames[7]);
localsurf->FrameAt(u.Mid() + uq, v.Mid() + vq, frames[8]);
As I know the Interval u,v is in gloable area, So I think the four lines above need to be modified as:
surf->FrameAt(u.Mid() - uq, v.Mid() - vq, frames[5]);
surf->FrameAt(u.Mid() - uq, v.Mid() + vq, frames[6]);
surf->FrameAt(u.Mid() + uq, v.Mid() - vq, frames[7]);
surf->FrameAt(u.Mid() + uq, v.Mid() + vq, frames[8]);
I'm not so convinced about it.Are there someone can check it?
Cheers!
Laijiren
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
BRL-CAD Developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
