On Wed, May 1, 2013 at 5:34 AM, Avneet Kaur <kauravneet...@gmail.com> wrote:
> On Mon, Apr 29, 2013 at 9:37 PM, Christopher Sean Morrison
> <brl...@mac.com> wrote:
>
> > Not just that you're going to reduce code, but what code, how, why, etc.
>
> Refactoring is not simply to reduce the LOC, it is to make the code
> easier to work with in the future.
>
That's a tall order, and such efforts *must* be specific and well thought
out - there is a tendency to view "code reduction" projects as a general
hunting license to wander around the code base and peck at various areas,
but that's not what this project idea is looking for.
You need to specify *which* parts of the existing code you are looking to
refactor, *why* they need refactoring (i.e. what *specifically* is wrong
with that bit of code), *what* you propose to do to change and test it,
and how those changes address the problem you've identified.
> > Also, how will you ensure nothing is broken?
>
> I will use Google C++ test framework for unit testing as I have a
> working experience of it.
>
>
> http://avneetkhasla.wordpress.com/2013/04/12/google-c-testing-frameworkgoogle-test-gtest/
>
Note that we aren't currently using Google test, so you're introducing a
new dependency. We *do* have unit testing for some of our libraries,
notably libbu. I'm not necessarily opposed to using Google's frameworks,
but a project proposing to use it would have to both make the case for why
it's worth adding (what does it give us that we can't do easily using our
current method) and convince us that the you have a good idea of how to
integrate such tests with our current testing setup. Specificity is again
key - you can't have too much.
> > That's great. Is there a reason you haven't considered a conversion
> project instead?
>
> Refactoring the code is a challenging task.
> I would prefer to proceed with this rather than DXF for the sake of my
> current interests as well as from learning point of view.
>
DXF isn't our only converter. If you're definitely into code scrubbing,
I'd recommend taking a look at this project idea:
http://brlcad.org/wiki/STEP_Libraries
That would have the benefit of being a code clean-up project that also
helps our most important converter and introduces you to a code base with
potential scope beyond just BRL-CAD. I assure you that cleaning up
STEPcode is a challenging task.
CY
------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
