On May 01, 2013, at 05:26 PM, Avneet Kaur <[email protected]> wrote:

On Wed, May 1, 2013 at 10:29 PM, Christopher Sean Morrison
<[email protected]> wrote:
> but you still should speak to what code, how, and why in your proposal.
>

What code - code (code smell) that's doing too many things is hard to maintain.
 
Not what type of code.  What actual code -- which directories, what files, what functions?  You need to identify what you intend to improve now, not just figure something out as you go along.

Why code - to improve maintainability and readability.

Again, not the point.  Why one particular set of files or directory versus another?

You need to be as specific as possible, like "what and how: refactor the bw file format reading/writing in the src/util directory into two new functions and update the places where bw reading/writing occurs. why: the same reading/writing is repeated in 24 places. validation plan: existing tests already exercise bw reading/writing, but plan to add one more explicit test based on example from wiki..." and so on.

We all know the merits of refactoring and code reduction.  We want to hear about what you plan to actually do.  If you don't know what files yet, you still have plenty of time to figure that out for your proposal.

Cheers!
Sean


------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
BRL-CAD Developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Reply via email to