On Fri, 20 Mar 2026 13:39:33 GMT, Erik Joelsson <[email protected]> wrote:
>> Harald Eilertsen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust FreeBSD Hsdis support to apply to *BSD. > > make/common/native/Link.gmk line 218: > >> 216: endif >> 217: ifeq ($(OPENJDK_TARGET_OS_ENV), bsd.netbsd) >> 218: /usr/sbin/paxctl +m $$@ > > I don't know what this tool is, but in general we prefer looking up tools in > configure and using them through a variable. This allows for a uniform way of > overriding any tool at configure time. Changed in latest patch by adding it to `make/autoconf/basic_tools.m4`, and use variable for access. > make/modules/java.desktop/Lib.gmk line 41: > >> 39: >> 40: ifeq ($(call isTargetOs, aix), false) >> 41: ifneq ($(OPENJDK_TARGET_OS_ENV), bsd.openbsd) > > Use isTargetOsEnv? > > Also please fix indentation of the block. Changes in latest version of the patch. ------------- PR Review Comment: https://git.openjdk.org/bsd-port/pull/6#discussion_r2974709616 PR Review Comment: https://git.openjdk.org/bsd-port/pull/6#discussion_r2974711852
