On Fri, 20 Mar 2026 14:27:29 GMT, Erik Joelsson <[email protected]> wrote:
>> Harald Eilertsen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust FreeBSD Hsdis support to apply to *BSD. > > make/RunTestsPrebuilt.gmk line 172: > >> 170: else ifeq ($(UNAME_OS), Darwin) >> 171: OPENJDK_TARGET_OS := macosx >> 172: else ifneq ($(findstring BSD,$(UNAME_OS)),) > > We prefer space after comma when possible. > https://openjdk.org/groups/build/doc/code-conventions.html I agree that's nicer. Changed in latest version of the patch. > make/modules/jdk.sctp/Java.gmk line 50: > >> 48: endif >> 49: >> 50: ifeq ($(OPENJDK_TARGET_OS_ENV), bsd.openbsd) > > Use macro? Same below. Changed in latest version of the patch. > make/test/JtregNativeJdk.gmk line 91: > >> 89: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exelauncher := -pthread >> 90: endif >> 91: ifeq ($(OPENJDK_TARGET_OS_ENV), bsd.openbsd) > > macro Changed in latest version of the patch. ------------- PR Review Comment: https://git.openjdk.org/bsd-port/pull/6#discussion_r2974768036 PR Review Comment: https://git.openjdk.org/bsd-port/pull/6#discussion_r2974763020 PR Review Comment: https://git.openjdk.org/bsd-port/pull/6#discussion_r2974765619
