On 4/19/21 3:22 PM, Mike Jonkmans wrote:
On Mon, Apr 19, 2021 at 11:27:13PM +0800, konsolebox wrote:
I looked at this code plenty of times and I really think the returned
value to expand_assignment_string_to_string (v, 0) needs to be freed
too when aval != 0.

...

The patch seems to be correct.

Moreover, I think that the line
        aval = expand_assignment_string_to_string (v, 0);
should be moved down below the next if-statement.

Because of the continue, there is a memory leak.

Good catch.


--
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    c...@case.edu    http://tiswww.cwru.edu/~chet/

Reply via email to