https://sourceware.org/bugzilla/show_bug.cgi?id=31881
--- Comment #16 from Nick Clifton <nickc at redhat dot com> --- (In reply to Rostislav Krasny from comment #13) > The last question is: will the bfd/configure script be ran by the > src-release.sh script only or also by a user who want to build from an > already created tarball? A good point, and something that I missed in my version of your patch. The answer is both. > In case of an already created tarball that part of > the bfd/configure script should not be ran because the bfd/version.h is > already created during creation of the tarball and also because there is no > Git repo available. > > If the bfd/configure us always running I propose to change this line: > > VERSION_DATE=$(cd $srcdir ; git log -1 --format=%cd --date=format:%Y%m%d) > > into that line: > > VERSION_DATE=$(cd $srcdir && git rev-parse --is-inside-work-tree > /dev/null > 2>&1 && git log -1 --format=%cd --date=format:%Y%m%d) > > And then generate the bfd/version.h file only if the $VERSION_DATE is not > empty. Thanks - I will give this a try. Cheers Nick -- You are receiving this mail because: You are on the CC list for the bug.