https://sourceware.org/bugzilla/show_bug.cgi?id=31881
--- Comment #21 from Nick Clifton <nickc at redhat dot com> --- (In reply to Rostislav Krasny from comment #20) Hi Rostislav (Sorry for the delay in replying - I am a bit overwhelmed at the moment). > Ok. Then what is the reason of generating VERSION_DATE from ChangeLog.git or > from the current date? These methods are meant to handle the case where the sources are not in a clone of the repository and not from a release tarball. > If this is done in case of a snapshot version, how > that snapshot version is made? Isn't it a regular tarball created by the > src-release.sh script sometime between official releases? Yes - in fact there is now a script on Sourceware that creates snapshots each time a commit is applied to the repository. > I just thought only three cases of the configure script being running are > possible: [1] building directly from the Git repo, [2] making a tarball > (release/snapshot/whatever) by the src-release.sh script from the Git repo, > and [3] building (release/snapshot/whatever) from a tarball previously > created in case 2. Only in cases 1 and 2 the configure script needs to > generate version.h and the $VERSION_DATE value, and in case 3 it should do > nothing about version.h and $VERSION_DATE because version.h is already > existing in the tarball. Right? Right - and this is what the fourth version of the patch does. >> I also found that the "git rev-parse --is-inside-work-tree" does not work >> as desired. If run outside of a repository it returns a fatal error and >> stops the rest of the scriptlet from running. So I have replaced it with >> a test for the .git directory at the top level of the source tree. Which >> I think should always work. > Does the configure script have 'set -e' somewhere? It does, but only inside the as_fn_exit() routine. > I didn't find it. Otherwise why the configure script stops in this case? I have no idea. I just found that it happened. Rather than investigate the cause however I just decided to use an alternative mechanism for checking for the existence of the git repository. Cheers Nick -- You are receiving this mail because: You are on the CC list for the bug.
