Bo Borgerson <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> if you make him happy, I'll probably be happy, too ;-) > > Hi Simon, > > This is an attempt to merge the coreutils and gnulib base64 libraries. > > My goal is to preserve the gnulib interface and behavior while also > supporting the coreutils extensions. > > This version of the patch should have good performance in both cases, as > well. > > Please let me know if this meets your requirements.
It meets mine, with one small change: I found "strict_newlines" to be a little unclear. If you use something like "ignore_newlines" instead, that's not only clearer to me, but with its reversed semantics it also lets you avoid three negations. Simon? >>From a302f7beca7d0e2bfcb7770ff31947e3d2965db2 Mon Sep 17 00:00:00 2001 > From: Bo Borgerson <[EMAIL PROTECTED]> > Date: Wed, 30 Apr 2008 17:40:38 -0400 > Subject: [PATCH] An upstream compatible base64 > > * gl/lib/base64.c (base64_decode_ctx): If no context structure was passed in, > treat newlines as garbage (this is the historical behavior). Formerly > base64_decode. > (base64_decode_alloc_ctx): Formerly base64_decode_alloc. > * gl/lib/base64.h (base64_decode): Macro for four-argument calls. > (base64_decode_alloc): Likewise. > * src/base64.c (do_decode): Call base64_decode_ctx instead of base64_decode. _______________________________________________ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils