Matthew Woehlke wrote: > Tail of the build log below; what else would you like? > > (I'm retrying the sparc build with the Sun compiler; you /don't/ want > to know what version of gcc this is ;-). But I don't expect success > due to AIX having what looks like the same problem.) > > ==== sparc/Solaris ==== > fsusage.c: In function `get_fs_usage': > fsusage.c:100: parse error before `struct' > fsusage.c:102: `fsd' undeclared (first use in this function) > fsusage.c:102: (Each undeclared identifier is reported only once > fsusage.c:102: for each function it appears in.)
Thanks for the report. That's a statement-before-decl: get_fs_usage (char const *file, char const *disk, struct fs_usage *fsp) { (void) disk; /* avoid argument-unused warning */ #if defined STAT_STATVFS /* POSIX */ struct statvfs fsd; Here's the fix I expect to push: (too bad I didn't fix this before making the snapshot) >From 22e91b1ffcc74d3cfa0466741dec6f54841e042f Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@redhat.com> Date: Thu, 19 Mar 2009 09:15:24 +0100 Subject: [PATCH] fsusage: avoid syntax error due to statement-before-declaration * lib/fsusage.c (get_fs_usage): Put warning-avoidance statement after all declarations. Reported by Matthew Woehlke in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/16231 --- ChangeLog | 7 +++++++ lib/fsusage.c | 2 +- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 86757f4..29bd643 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2009-03-19 Jim Meyering <meyer...@redhat.com> + + fsusage: avoid syntax error due to statement-before-declaration + * lib/fsusage.c (get_fs_usage): Put warning-avoidance statement + after all declarations. Reported by Matthew Woehlke in + http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/16231 + 2009-03-18 Eric Blake <e...@byu.net> build-aux/compile: sync from automake diff --git a/lib/fsusage.c b/lib/fsusage.c index ade4195..db0d3bc 100644 --- a/lib/fsusage.c +++ b/lib/fsusage.c @@ -94,7 +94,6 @@ int get_fs_usage (char const *file, char const *disk, struct fs_usage *fsp) { - (void) disk; /* avoid argument-unused warning */ #if defined STAT_STATVFS /* POSIX */ struct statvfs fsd; @@ -233,6 +232,7 @@ get_fs_usage (char const *file, char const *disk, struct fs_usage *fsp) #endif + (void) disk; /* avoid argument-unused warning */ return 0; } -- 1.6.2.rc1.285.gc5f54 _______________________________________________ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils