-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to Jim Meyering on 11/19/2009 2:18 AM: > This was introduced by 0cc0424119ec66c9005fb905cc1001a64b978ce3, > to avoid test failures on Cygwin. Unfortunately, if you have an insecure > PATH, you now lose on Linux, even though those tests don't search > PATH at all. Before, PATH was simply unset, but that wasn't portable > to Cygwin. > > Here's a patch that avoids failure even if you have > an insecure PATH directory, and should also work on Cygwin:
In addition to the nits you've already addressed... > +# Taint checking requires a sanitized $PATH. This script performs no $PATH > +# search, so on most Unix-based systems, it is fine simply to clear > $ENV{PATH}. > +# However, on Cygwin, it's used to find cygwin.dll, so set it. s/cygwin.dll/cygwin1.dll/ > +$ENV{'PATH'} = '/bin:/usr/bin'; I confirmed that this does indeed pass on cygwin. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAksFQVcACgkQ84KuGfSFAYCtAwCfeb5bjF+K4eUJCjhjBDuxoFcf S0gAn2bmPtGvRc+yJGwxiKcBCNp+7w7x =SL7B -----END PGP SIGNATURE-----