Eric Blake wrote: > According to Jim Meyering on 11/19/2009 2:18 AM: >> This was introduced by 0cc0424119ec66c9005fb905cc1001a64b978ce3, >> to avoid test failures on Cygwin. Unfortunately, if you have an insecure >> PATH, you now lose on Linux, even though those tests don't search >> PATH at all. Before, PATH was simply unset, but that wasn't portable >> to Cygwin. >> >> Here's a patch that avoids failure even if you have >> an insecure PATH directory, and should also work on Cygwin: > > In addition to the nits you've already addressed... > >> +# Taint checking requires a sanitized $PATH. This script performs no $PATH >> +# search, so on most Unix-based systems, it is fine simply to clear >> $ENV{PATH}. >> +# However, on Cygwin, it's used to find cygwin.dll, so set it. > > s/cygwin.dll/cygwin1.dll/
Thanks for that and for testing. I didn't see your correction until just now. >From ddea7b10780c17f4ae90516f0e63e1ec1ba6a963 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@redhat.com> Date: Fri, 20 Nov 2009 12:58:51 +0100 Subject: [PATCH] maint: correct comments in test scripts * tests/misc/pwd-long: Fix spelling of cygwin1.dll in comment. * tests/rm/fail-eperm: Likewise. Reported by Eric Blake. --- tests/misc/pwd-long | 2 +- tests/rm/fail-eperm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/misc/pwd-long b/tests/misc/pwd-long index df1590c..5419519 100755 --- a/tests/misc/pwd-long +++ b/tests/misc/pwd-long @@ -59,7 +59,7 @@ $ENV{IFS} = ''; # Taint checking requires a sanitized $PATH. This script performs no $PATH # search, so on most Unix-based systems, it is fine simply to clear $ENV{PATH}. -# However, on Cygwin, it's used to find cygwin.dll, so set it. +# However, on Cygwin, it's used to find cygwin1.dll, so set it. $ENV{PATH} = '/bin:/usr/bin'; # Save CWD's device and inode numbers. diff --git a/tests/rm/fail-eperm b/tests/rm/fail-eperm index 16811c2..3f4d72a 100755 --- a/tests/rm/fail-eperm +++ b/tests/rm/fail-eperm @@ -37,7 +37,7 @@ $ENV{IFS} = ''; # Taint checking requires a sanitized $PATH. This script performs no $PATH # search, so on most Unix-based systems, it is fine simply to clear $ENV{PATH}. -# However, on Cygwin, it's used to find cygwin.dll, so set it. +# However, on Cygwin, it's used to find cygwin1.dll, so set it. $ENV{PATH} = '/bin:/usr/bin'; my @dir_list = qw(/tmp /var/tmp /usr/tmp); -- 1.6.5.3.433.g11067