> From: Yue Yi <[email protected]> > Date: Mon, 12 Oct 2026 02:11:44 +0800 > Cc: Paul Eggert <[email protected]>, [email protected], > [email protected] > > > From: Eli Zaretskii > > Sun, 11 Oct 2026 08:34:17 +0300 > > > > > On 2026-10-10 00:44, Eli Zaretskii wrote: > > > > Paul, any suggestions given the above? > > > > > > I installed the attached patch into Gnulib and propagated this into Emacs > > > master. This should fix Emacs's issue with _UCRT. > > > > Thanks. Yue Yi, could you please see if the warnings about the > > _gl_consolesafe_* functions not having prototypes are now gone? > > Yes, I can no longer find the relevant warnings in the build output. The > fix worked, thanks. > > However, following the Gnulib update (c4a6483) and the new fix > (6d8e17c), a new warning has appeared, looking roughly like this: > > make[2]: Entering directory '/d/emacs-ucrt/src' > GEN globals.h > CC dispnew.o > In file included from ./conf_post.h:38, > from ./config.h:3917, > from dispnew.c:21: > D:/emacs-ucrt/nt/inc/ms-w32.h:221:9: warning: 'localtime' redefined > 221 | #define localtime sys_localtime > | ^~~~~~~~~ > In file included from D:/emacs-ucrt/nt/inc/ms-w32.h:173: > ../lib/time.h:925:13: note: this is the location of the previous definition > 925 | # define localtime rpl_localtime > | ^~~~~~~~~ > CC frame.o > > Perhaps this needs to be fixed as well?
Thanks, I hope I've fixed that now on the master branch.
