On 2026-10-12 13:45, Paul Eggert wrote:
On 2026-10-12 05:17, Eli Zaretskii wrote:
Why do you think the mingw32 doesn't want to replace mktime?
Because of this (in master):
$ git grep mktime nt
nt/mingw-cfg.site:# Avoid compiling gnulib mktime
nt/mingw-cfg.site:gl_cv_func_working_mktime=yes
To fix that, I propose installing the attached. Otherwise I don't see
how mktime could work on mingw, as the system mktime won't sanitize TZ.From 93687957da7d2c6cbcc6ed215ee9b8c13f087107 Mon Sep 17 00:00:00 2001
From: Paul Eggert <[email protected]>
Date: Mon, 12 Oct 2026 14:48:18 -0700
Subject: [PATCH] Do not avoid compiling Gnulib mktime on mingw
* nt/mingw-cfg.site (gl_cv_func_working_mktime): Remove.
---
nt/mingw-cfg.site | 2 --
1 file changed, 2 deletions(-)
diff --git a/nt/mingw-cfg.site b/nt/mingw-cfg.site
index 36d64eca2cc..ba7d952ae5b 100644
--- a/nt/mingw-cfg.site
+++ b/nt/mingw-cfg.site
@@ -134,8 +134,6 @@ ac_cv_have_decl_alarm=yes
gl_cv_func_dup2_works=yes
# Defined in w32.c
ac_cv_func_getloadavg=yes
-# Avoid compiling gnulib mktime
-gl_cv_func_working_mktime=yes
# Implemented in w32.c
ac_cv_func_pipe2=yes
ac_cv_have_decl_unsetenv=yes
--
2.56.0
