Follow-up Comment #20, bug #24785 (project gnustep):

Ah ... I thought BOOL was typedef'ed as int.  As it's an unsigned char, the
cause of the problem (and reason the fix works) is clear.

However, I think instead of the double cast, we should explicitly mask the
return result with 0xff and add a comment to say that old code may only set
the low byte of the result, so we need to mask out the top bytes.  IMO this
would make the whole issue much clearer if/when someone looks at the source in
future.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24785>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



_______________________________________________
Bug-gnustep mailing list
Bug-gnustep@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnustep

Reply via email to