Update of bug #67602 (group groff):

                Severity:              3 - Normal => 5 - Blocker
                  Status:                   Fixed => Confirmed

    _______________________________________________________

Follow-up Comment #8:

Unfortunately, the committed fix does not work and breaks pdf.tmac.

The pdf:lookup macro should do two things:-

Set pdf:lookup-result if a given destination name is found.
Set pdf:lookup-value to the text used when the destination named, i.e.

.pdfbookmark -T destination-name -- 1 text
.pdfbookmark -T Intro -- 1 Introduction to Programming

So:-

.pdf:lookup Intro

Should return this (if "Intro" exists as a destination):-

pdf:lookup-result = non-empty (actually returns "Intro")
pdf:lookup-value = "Introduction to Programming"

The purported fix below does no lookup at all, it simply sets
pdf:lookup-result to \\*1!!!

So whatever you "lookup" (so long as it is not the empty string) will return
as "found”, and there is no way of retrieving the text associated with the
destination.

Currently git is "red" because neither Groff-man-pages.pdf nor mom-pdf.pdf are
building correctly. In our man pages book (and Alex's book) a .MR to a man
page outside the book should result in a man:/ url but because the pseudo
lookup always returns true (non-empty) this is not happening. For the
mom-pdf.pdf you will notice some (see: "") rather than the appropriate text
appearing, because pdf:lookup-value is not being set to the text associated
with the destination.

I did mention in comment #5 that you should retain the current api, so I don't
understand why pdf:lookup-value has "vanished". I understand your desire to
reduce the large document production time down from 40 minutes to 30 seconds,
which is what it took before you made changes to pdf.tmac whilst I was on a
sabbatical. I will remind you that the code in dj-gropdf-ng does do a proper
lookup solution in about 30 seconds, but you have not brought it over to
master.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?67602>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to