Follow-up Comment #11, bug #67602 (group groff): On Tuesday, 21 October 2025 18:52:00 BST G. Branden Robinson wrote: > Follow-up Comment #9, bug #67602 (group groff): > [...] >> Currently git is "red" because neither Groff-man-pages.pdf > > I checked this document specifically and could not find problems--I > clicked on multiple internal bookmarks at the extremes of the document > and they navigated (in Okular) without trouble. > > And the tree _isn't_ red, it's green--because we don't have a test > script that checks PDF bookmarking for correctness.
Ok, its only red if a test fails. I just meant that pdf.tmac was not working properly after your fix, and a cursory view of the change was enough to know it could not work. > Something that fragile should probably have a unit test for it. Please expand on what you mean by "fragile"? Is it because you have now twice broken code that was working? [...] >> I did mention in comment #5 that you should retain the current api, so >> I don't understand why pdf:lookup-value has "vanished". > > _At the time_, it didn't seem necessary to retain while solving the > problem. Happy to restore that string name if it is. The answer is in my previous comment. -result tells you if the lookup is successful, -value contains the text associated with the named destination. >> I understand your desire to reduce the large document production time >> down from 40 minutes to 30 seconds, > > I wonder who put that notion in my head. ;-) > >> which is what it took before you made changes to pdf.tmac whilst I was >> on a sabbatical. > > True, and you've raised this point before--and as I noted then, you > similarly swooped in after a period of inactivity with some changes > while I was about four days into bereavement leave, so to speak. You have written before "(Since you're not on the _groff_ list for a while, you may not know that I had a death in the immediate family this week and, in an employment context, I'd be on bereavement leave right now.)" And you are absolutely correct, I was not on the groff list (but remained on groff_bug), so our behaviours were different, you were aware of my sabbatical, I was unaware of your sad bereavement. > https://cgit.git.savannah.gnu.org/cgit/groff.git/commit/?id=98b0c1db47659cd2 > 03b7eaba8382e1e7a36d0288 > https://cgit.git.savannah.gnu.org/cgit/groff.git/commit/?id=2387949ffc11b75 > 3dd91480dcb85be6c22819790 > https://cgit.git.savannah.gnu.org/cgit/groff.git/commit/?id=cbe5a7802df5ff3 > a9f84a42e277cf3925a1eb303 > > Either that conduct is a problem for both of us, or it isn't. If it > isn't, it isn't worth harping on when I make a mistake. I am sorry if my commits during your bereavement caused any pain for you, I would have delayed them if I had known. Your conduct then did upset me, because you knew I was on sabbatical, you also knew I was against using a looping solution (my grandsons "solution" if you remember) for performance reasons. I, on the other hand, had no idea of your bereavement. And your commit here suffered one of the same deficiencies as your sabbatical commit, namely it did not return the text associated with the named destination - which is why it did not work with mom, a fact you recognised at the time. >> I will remind you that the code in dj-gropdf-ng does do a proper >> lookup solution in about 30 seconds, but you have not brought it over >> to master. > > I can certainly have a look. I wanted to see if I could solve the > problem myself, especially since the "aliasing trick" seemed promising. > > My advice is to spend less time expressing offense over regressions. > Writing scripts to catch them is a better use of everyone's time. I don't think I was expressing offence, merely stating that you have "previous" in this area. > We have over 280 examples in the tree already of how to do that. > All written in bash (+ utilities I infrequently use), not something I'm very conversant with. > _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/bugs/?67602> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
signature.asc
Description: PGP signature
