On Sat, Sep 14, 2019 at 10:22 AM Paul Smith <psm...@gnu.org> wrote: > and, I've checked with a makefile invoked by the test suite and this > setting is in effect, even if the shell invoking run_make_tests.pl has > a different setting for LC_ALL.
This should be sufficient. > Furthermore, we clear out the environment so that only a set number of > variables are actually reserved, and LANG is not one of them (nor is > LC_MESSAGES), so setting LANG in the run_make_tests shell script should > not have any effect. LANG and LC_MESSAGES both affect tests on certain hosts. > I need to understand your failure situation better before applying this > change. Paul, i assume the system on which you test can print messages in various locales. I have a host which cannot do anything other than the default locale. Tests pass on that host regardless of env variables. Here is an example from a host which honors env variables $ export LC_MESSAGES=fr_CA.UTF-8; echo 'all: ; ./asdf' | ../l64/make -f- ./asdf make: ./asdf: Aucun fichier ou dossier de ce type make: *** [/tmp/GmvTj9K1;1: all] Error 127 What does export LC_MESSAGES=fr_CA.UTF-8; echo 'all: ; ./asdf' | ../l64/make -f- print on your host? Below are a couple of examples of failures on aix and linux. These tests pass when LANG and LC_MESSAGES are unset or set to C. $ LANG=en_US ./run_make_tests -make_path ../i32/make features/errors; cat work/features/errors.diff.3 ------------------------------------------------------------------------------ Running tests for GNU make on AIX 1 00F85A9D4C00 GNU Make 4.2.90 ------------------------------------------------------------------------------ Clearing work... Making work dirs... features/errors ......................................... FAILED (4/7 passed) 3 Tests in 1 Category Failed (See .diff* files in work dir for details) :-( *** work/features/errors.base.3 Sat Sep 14 15:16:57 2019 --- work/features/errors.log.3 Sat Sep 14 15:16:57 2019 *************** *** 1,3 **** ./foobarbazbozblat xx yy ! make: ./foobarbazbozblat: A file or directory in the path name does not exist. make: [work/features/errors.mk.2;2: one] Error 127 (ignored) --- 1,3 ---- ./foobarbazbozblat xx yy ! make: ./foobarbazbozblat: No such file or directory make: [work/features/errors.mk.2;2: one] Error 127 (ignored) $ $ LC_MESSAGES=ru_RU ./run_make_tests -make_path ../l32/make features/errors; cat work/features/errors.diff.3 ------------------------------------------------------------------------------ Running tests for GNU make on Linux 2.6.32-642.6.2.el6.x86_64 x86_64 GNU Make 4.2.90 ------------------------------------------------------------------------------ Clearing work... Making work dirs... features/errors ......................................... FAILED (4/7 passed) 3 Tests in 1 Category Failed (See .diff* files in work dir for details) :-( *** work/features/errors.base.3 Sat Sep 14 15:19:22 2019 --- work/features/errors.log.3 Sat Sep 14 15:19:22 2019 *************** *** 1,3 **** ./foobarbazbozblat xx yy ! make: ./foobarbazbozblat: ??? ?????? ????? ??? ???????? make: [work/features/errors.mk.2;2: one] Error 127 (ignored) --- 1,3 ---- ./foobarbazbozblat xx yy ! make: ./foobarbazbozblat: No such file or directory make: [work/features/errors.mk.2;2: one] Error 127 (ignored) regards, Dmitry _______________________________________________ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make