On 10/08, Tim Rühsen wrote:
I wasn't originally using the TEST_EXTENSIONS and PY_LOG_COMPILER variables. But as you suggest it is a more cleaner way of doing things. Especially if we want to merge other tests into it. So I'll make the changes and add PYTHONPATH.Hi Darshit,maybe we should somehow merge the patches... Maybe you can take a few things from my patch before pushing !? 1. you are right with the XFAIL_TESTS (didn't I do that ?) 2. you are right with omitting SYSTEM_WGETRC from AM_TESTS_ENVIRONMENT 3. AM_TESTS_ENVIRONMENT needs export PYTHONPATH... when using TEST_EXTENSIONS = .py PY_LOG_COMPILER = python3 This allows also allows us to use TESTS_ENVIRONMENT variable from the command line. I guess that is cleaner... especially if we mix other kinds of executables into the tests (e.g. the unit test...).
The Python tests still need to support the TESTS_ENVIRONMENT variable. I'm busy from tomorrow onwards so I may not be able to work on it for a while now. Will look into it as soon as I can.That should be it than. What should work in the end: - make check - make check -jn - cd tests; ./Test-... - make distcheck - make distcheck -jn - TESTS_ENVIRONMENT="LC_ALL=whatever" make check [-jn] - cd tests; TESTS_ENVIRONMENT="LC_ALL=whatever" ./Test-... (i used to test LC_ALL=tr_TR.utf8 for TESTS_ENVIRONMENT)
Regards, Tim
--- end quoted text --- -- Thanking You, Darshit Shah
pgp5Ty1M0Rz4w.pgp
Description: PGP signature
