I think the proto files are broken. I'm currently on mobile, but will have a look at them asap and send in the fixes On 23-Oct-2014 6:59 am, "Tim Rühsen" <[email protected]> wrote:
> Am Mittwoch, 8. Oktober 2014, 19:24:32 schrieb 'Darshit Shah': > > On 10/08, Tim Rühsen wrote: > > >Hi Darshit, > > > > > >maybe we should somehow merge the patches... > > > > > >Maybe you can take a few things from my patch before pushing !? > > > > > >1. you are right with the XFAIL_TESTS (didn't I do that ?) > > >2. you are right with omitting SYSTEM_WGETRC from AM_TESTS_ENVIRONMENT > > >3. AM_TESTS_ENVIRONMENT needs export PYTHONPATH... when using > > > > > > TEST_EXTENSIONS = .py > > > PY_LOG_COMPILER = python3 > > > > > >This allows also allows us to use TESTS_ENVIRONMENT variable from the > > >command line. I guess that is cleaner... especially if we mix other > kinds > > >of executables into the tests (e.g. the unit test...). > > > > I wasn't originally using the TEST_EXTENSIONS and PY_LOG_COMPILER > variables. > > But as you suggest it is a more cleaner way of doing things. Especially > if > > we want to merge other tests into it. So I'll make the changes and add > > PYTHONPATH. > > >That should be it than. > > > > > >What should work in the end: > > >- make check > > >- make check -jn > > >- cd tests; ./Test-... > > >- make distcheck > > >- make distcheck -jn > > >- TESTS_ENVIRONMENT="LC_ALL=whatever" make check [-jn] > > >- cd tests; TESTS_ENVIRONMENT="LC_ALL=whatever" ./Test-... > > >(i used to test LC_ALL=tr_TR.utf8 for TESTS_ENVIRONMENT) > > > > The Python tests still need to support the TESTS_ENVIRONMENT variable. > I'm > > busy from tomorrow onwards so I may not be able to work on it for a while > > now. Will look into it as soon as I can. > > > > >Regards, Tim > > > > --- end quoted text --- > > Hi Darhsit, > > I am merging our patches right now to push them. There seems to be a > missing > file testenv/misc/constants.py, used by Test-Proto.py and Test-Parallel- > Proto.py (which are not in Makefile.am - should I add them ?). Could you > send > me this file and brush all up, test here and would like to push it - if you > don't mind. > > Tim >
