https://www.rtems.org/bugzilla/show_bug.cgi?id=2185
Sebastian Huber <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian.huber@embedded-br | |ains.de --- Comment #1 from Sebastian Huber <[email protected]> 2014-08-07 07:43:56 CDT --- It is easier if you send patches to the [email protected] list. In general such a change looks all right, but we have to make sure that existing drivers don't get confused. The integer types should fit, e.g. partlen should be size_t. Declarations should be at the block begin, for the coding style please have a look at http://www.rtems.org/wiki/index.php/Coding_Conventions I would avoid the multiple modulo operations since they may be really expensive on some targets. -- Configure bugmail: https://www.rtems.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
