Merge request 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209 was 
reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138479

 > +
 > +This BSP supports the Real-time Processing Unit (RPU) on Xilinx Versal
 > + Adaptive SoCs. The RPU has two Cortex-R5 cores which can operate in 
 > lock-step

These lines should start in column 1.

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138480

 > +
 > +The `versal_rpu_lock_step` BSP variant is intended to be used for the RPU in
 > +lock-step mode. In this case, the ATCM and BTCM could be used as a combined

@opticron Should the acronyms be spelled out here?

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138481

 > +
 > +The clock driver uses the Triple Timer Counter 3 (TTC3) as the timer 
 > interrupt
 > + source.

Left margin again.

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138482

 > +
 > +For quick turnaround during testing, it is recommended to use Cortex-A72 
 > linux
 > + via `remoteproc` driver to avoid repeated `BOOT.bin` generation.

Left margin

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138483

 > +## Linux device tree
 > +
 > +DDR RAM used by RTEMS application should be specified in a 
 > `reserved-memory` node

I think the "," can be deleted. But it should be against the end of the 
previous word if it stays.

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138484

 > +
 > +RTEMS application could be added to the `BOOT.BIN` with a dedicated entry 
 > into the
 > + BIF file.

First column

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138485

 > +
 > +> During Linux boot, unused peripherals are [powered 
 > down](https://docs.amd.com/r/2025.1-English/ug1304-versal-acap-ssdg/Power-Management-Using-XPm_InitFinalize
 > +), including triple timer counters (TTC).

), should be on the previous line.

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138486

 > +In order to check TTC configuration and status from Linux, TTC node needs 
 > to be
 > + requested.
 > +```shell

Blank line above.

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138487

 > + list (see `IsDevExcluded()` in 
 > [xpm_subsystem.c](https://github.com/Xilinx/embeddedsw/blob/master/lib/sw_services/xilpm/src/versal_common/server/xpm_subsystem.c#L171)).
 > +
 > +## TTC debug

@opticron Should the acronym be spelled out?

--
  
Joel Sherrill started a new discussion on user/bsps/arm/xilinx-versal-rpu.md: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209#note_138488

 > +> - secure: unused.
 > +
 > +

Extra blank line.


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/docs/rtems-docs/-/merge_requests/209
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to