Kinsey Moore started a new discussion on bsps/aarch64/rk3399/start/bspstartmmu.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/894#note_139622 > + { /* GIC500 */ > + .begin = 0xFEE00000ULL, > + .end = 0xFF000000ULL, > + .flags = AARCH64_MMU_DEVICE > + }, > + { /* NS16550 device */ > + .begin = RK3399_UART_BASE, > + .end = RK3399_UART_BASE+RK3399_UART_SIZE, > + .flags = AARCH64_MMU_DEVICE > + }, > +}; > +/* > + * Make weak and let the user override. > + */ > +BSP_START_TEXT_SECTION void > +rk3399_setup_mmu_and_cache( void ) __attribute__ ((weak)); Instead of embedding this table in bspstartmmu.c and making the setup function weak, this should instead follow the same form as the ZynqMP BSP and break the table out into its own file with a size so that the pair can be overridden by the application if necessary. This removes the necessity of a weak function definition. Also, the prototype should go in a header instead of being reproduced in multiple source files. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/894#note_139622 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
