Gedare Bloom commented on a discussion on cpukit/score/src/corerwlockrelease.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/747#note_140251

 >    }
 >  
 >    _Assert(
 > -    the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_WRITING
 > -      || ( the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_READING
 > -        && the_rwlock->number_of_readers == 0 )
 > +    the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_WRITING ||
 > +    ( the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_READING &&
 > +      the_rwlock->number_of_readers == 0 )

I think we have to pick one. the LLVM default style puts them at the end of the 
line (break after the binary operator). I've found that style helps to see the 
logic indent levels easier. There's not a clear precedent in RTEMS, which is 
probably why we had that note about "matter of choice".

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/747#note_140251
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to