Joel Sherrill commented on a discussion on 
cpukit/score/src/corerwlockrelease.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/747#note_140264

 >    }
 >  
 >    _Assert(
 > -    the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_WRITING
 > -      || ( the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_READING
 > -        && the_rwlock->number_of_readers == 0 )
 > +    the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_WRITING ||
 > +    ( the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_READING &&
 > +      the_rwlock->number_of_readers == 0 )

This change is right per what OAR style does. && and || go at end of a line.

I thought that spaces after an opening ( and before the closing ) were not in 
OAR style. 

We may have evolved away from that over the years. But the code had to stay 
under 80 columns and those spaces would have been making lines longer.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/747#note_140264
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to