Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on cpukit/include/mqueue.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146652 > + /** This is the number of messages currently queued */ > long mq_curmsgs; > + /** RTEMS extension: waiting discipline (0 = FIFO, 1 = priority) */ Please put these in an ifdef __rtems__ guard. Eventually this header file needs to move to newlib and any RTEMS specifics need to be there only when building for RTEMS l. -- Joel Sherrill started a new discussion on spec/build/testsuites/psxtests/grp.yml: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146653 > copyrights: > -- Copyright (C) 2020 embedded brains GmbH & Co. KG > + - Copyright (C) 2020 embedded brains GmbH & Co. KG The changes to this file look like primarily format changes. If it is incorrectly formatted, please move the reformatting to another MR. @gedare thoughts on yaml formatting appreciated. -- Joel Sherrill started a new discussion on testsuites/psxtests/psxmsgq05/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146654 > +#ifdef HAVE_CONFIG_H This needs the standard RTEMS file header. -- Joel Sherrill started a new discussion on testsuites/psxtests/psxmsgq05/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146655 > +static mqd_t mq; > + > +/* ========================= Thread ========================= */ Please use RTEMS format for comments. This also doesn't seem to be an illuminating comment. -- Joel Sherrill started a new discussion on testsuites/psxtests/psxmsgq05/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084#note_146656 > + pthread_create( &threads[0], &pattr, receive_thread, (void*)(intptr_t)0 > ); > + > + pthread_create( &threads[1], &pattr, receive_thread, (void*)(intptr_t)1 > ); Every POSIX call should check the return code using the test assertion. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1084 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
