Sebastian Huber started a new discussion on 
cpukit/include/rtems/confdefs/inittask.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1208#note_148659

 >  #endif
 >  
 >  /*
 > - * Ignore the following warnings from g++ and clang in the uses of
 > - * _CONFIGURE_ASSERT_NOT_NULL() below:
 > - *
 > - * warning: the address of 'void Init()' will never be NULL [-Waddress]
 > - *
 > - * warning: comparison of function 'Init' not equal to a null pointer is 
 > always
 > - * true [-Wtautological-pointer-compare]
 > +  * _CONFIGURE_ASSERT_NOT_NULL is used to validate function pointers at

The original comment contained the precise warning messages. Why do you remove 
them?

Not everyone knows what exempli gratia means, try to replace e.g. with _for 
example_.

Keep the comment formatting.

Instead of duplicating descriptions, maybe add the description of 
`_CONFIGURE_ASSERT_NOT_NULL()` to the macro definition in Doxygen format.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1208#note_148659
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to