Joel Sherrill commented: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1216#note_149013


The changes look OK but a baud rate of 0 is valid per POSIX 
[tcsetattr()](https://pubs.opengroup.org/onlinepubs/009696799/functions/tcsetattr.html).
 B0 is very old school UNIX and setting the baud rate to that indicates that 
the "the modem control lines shall no longer be asserted. Normally, this shall 
disconnect the line." AFAIK no RTEMS UART drivers have support for modem 
control lines so this is a NA. 

I got caught by this while trying out [CodeSonar on 
RTEMS](https://flightsoftware.jhuapl.edu/files/_site/workshops/old_archive/2014/).
 It was flagged as a missed divide by zero but is actually a feature not 
supported by the driver.

I added https://gitlab.rtems.org/rtems/docs/rtems-docs/-/issues/144 to ensure 
this gets documented and #5558 for reviewing all the UART/console drivers to 
discuss this.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1216#note_149013
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to