Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1229 
was reviewed by Chris Johns

--
  
Chris Johns commented on a discussion on bsps/shared/dev/gpio/gpio-support.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1229#note_149530

 > +    _Assert( sc == RTEMS_SUCCESSFUL ); \
 > +    (void) sc; \
 > +  while (0)

I have not looked at this code before. It should be converted to use self 
contain mutexes and not object id based semaphores. This would also mean the 
lock and unlock macros could be removed as the self contains mutex lock and 
unlock do not return a status code.


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1229
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to