Heinz Junkes commented: https://gitlab.rtems.org/rtems/rtos/rtems/-/commit/0194d301f3e42f0a636bac44201a603a65a9e12e#note_151339 Unfortunately, the kernel can no longer be built with this commit: e.g. ``` [1108/1556] Compiling cpukit/dev/serial/sc16is752.c ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c: In function 'rtems_fdt_unload': ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:592:9: error: too few arguments to function 'rtems_fdt_valid_handle_unprotected'; expected 2, have 1 592 | if ( !rtems_fdt_valid_handle_unprotected( handle ) ) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from ../../../cpukit/libmisc/rtems-fdt/rtems-fdt.c:40: ../../../cpukit/include/rtems/rtems-fdtimpl.h:104:20: note: declared here 104 | static inline bool rtems_fdt_valid_handle_unprotected( | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Waf: Leaving directory `/Volumes/Epics/RTEMS_BBB/kernel/build/arm/beagleboneblack' Build failed -> task in 'rtemscpu' failed with exit status 1 (run with -v to display more information) ``` The function signature in rtems-fdtimpl.h expects 2 arguments but rtems-fdt.c is calling it with 1. fix: ``` diff --git a/cpukit/libmisc/rtems-fdt/rtems-fdt.c b/cpukit/libmisc/rtems-fdt/rtems-fdt.c index 593fccfc6c..5ccc05c5c7 100644 --- a/cpukit/libmisc/rtems-fdt/rtems-fdt.c +++ b/cpukit/libmisc/rtems-fdt/rtems-fdt.c @@ -589,7 +589,7 @@ int rtems_fdt_unload( rtems_fdt_handle *handle ) fdt = rtems_fdt_lock(); - if ( !rtems_fdt_valid_handle_unprotected( handle ) ) { + if ( !rtems_fdt_valid_handle_unprotected( handle, fdt ) ) { rtems_fdt_unlock( fdt ); return -RTEMS_FDT_ERR_INVALID_HANDLE; } ``` -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/commit/0194d301f3e42f0a636bac44201a603a65a9e12e#note_151339 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
