Yang Zhang commented on a discussion on bsps/shared/dev/gpio/gpio-support.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1281#note_151983

 >         );
 >  
 >    if ( sc != RTEMS_SUCCESSFUL ) {
 > -    sc = rtems_gpio_release_multiple_pins(
 > +    release_sc = rtems_gpio_release_multiple_pins(

In the gpio_multi_select failure paths the function returns a constant, so I 
dropped release_sc and reuse sc there. I kept it only in the CREATE_LOCK 
failure path, where the returned sc carries the lock-creation error and must 
not be clobbered by the release calls while still asserting they succeed.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1281#note_151983
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to