Gedare Bloom started a new discussion on bsps/i386/shared/irq/apic.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1121#note_152417 > +#include <bsp/apic.h> > + > +volatile uint32_t* i386_lapic_base; > +extern void _pc386_delay(void); > + > +#ifdef RTEMS_SMP > +/* Maps the processor index to the Local APIC ID */ > +uint8_t i386_lapic_to_cpu_map[APIC_BCAST_ID]; > +uint8_t i386_cpu_to_lapic_map[APIC_BCAST_ID]; > +static uint32_t lapic_count = 0; same for these, if we could make them `static` to this file, and expose them through function calls, it would improve the code safety and modularity (encapsulation) -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1121#note_152417 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
