Merge request https://gitlab.rtems.org/rtems/tools/rtems-deployment/-/merge_requests/36 was reviewed by Chris Johns
-- Chris Johns started a new discussion on pkg/__init__.py: https://gitlab.rtems.org/rtems/tools/rtems-deployment/-/merge_requests/36#note_153125 > + _freebsd = None > + > +# Determine runtime packager selection for build() calls based on host Why bother checking for Linux on FreeBSD? The logic below determines what to look for by inspecting the OS `uname`. -- Chris Johns started a new discussion on pkg/__init__.py: https://gitlab.rtems.org/rtems/tools/rtems-deployment/-/merge_requests/36#note_153126 > + runtime_packager = _freebsd > + elif system == 'Linux' and _linux is not None: > + runtime_packager = _linux The `packager` is an important abstraction as it says all packing system must the same API. I am not sure why you have replaced the approach taken with the `runtime_packager` variable. Also if you set a variables like `runtime_packager` inside logic blocks please make sure you declare it above as I had with `packager` which was removed. -- View it on GitLab: https://gitlab.rtems.org/rtems/tools/rtems-deployment/-/merge_requests/36 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-asxko3h2124g780pg1bilgfaw-3n/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
