Merge request https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/48 was reviewed by Pavel Pisa
-- Pavel Pisa started a new discussion on rtemslwip/tms570/tms570_netif.c: https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/48#note_154994 > + TMS570_BALL_T4_MII_RXCLK, > + TMS570_BALL_U7_MII_TX_CLK, > + TMS570_PIN_AND_FNC(TMS570_BALL_WITH_MMR(87, 3), 0), /* MDIO <- F4 > */ I would prefer to use symbolic pins/balls name there but it seems that there is some mismatch between the [bsps/arm/tms570/include/bsp/tms570lc4357-pins.h](https://gitlab.rtems.org/rtems/rtos/rtems/-/blob/main/bsps/arm/tms570/include/bsp/tms570lc4357-pins.h) locations and this list. There is defined alternative pin `TMS570_BALL_G3_MDIO` but not F4 variant... So the include is not complete. The `TMS570LC4357_PINMMR_DEFAULT_INIT_LIST` then mismatches given board as well but it would match HDK probably so there should be two variants somehow switched in the future, one for Launchpad and one for HDK... Not as critical for now. -- View it on GitLab: https://gitlab.rtems.org/rtems/pkg/rtems-lwip/-/merge_requests/48 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/sent_notifications/4-9rs8hepgj8esmkkp576a3crt5-m/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
