Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on bsps/powerpc/mvme2100/include/bsp/VMEConfig.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159180 > + * NOTE: If a) and b) are not implemented by the BSP > + * BSP_PCI_VME_DRIVER_DOES_EOI must be *undefined*. > + * Empty comment line. -- Joel Sherrill started a new discussion on bsps/powerpc/mvme2100/include/bsp/irq.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159181 > + * by RTEMS to write interrupt handlers. > + * > + * This code is heavily inspired by the public specification of STREAM V2 I honestly bet this looks nothing like Chorus Stream V2 anymore. This was referring to the "old new interrupt api". Yes we are now on at least the third interrupt API for BSPs. This is the second -- hence "old new". Please remove these references. -- Joel Sherrill started a new discussion on bsps/powerpc/mvme2100/include/bsp/irq.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159182 > +#define BSP_PCI_IRQ_MAX_OFFSET > \ > + (BSP_PCI_IRQ_LOWEST_OFFSET + BSP_PCI_IRQ_NUMBER - 1) > +/* Are the lack of blank lines before comment blocks in the IRQ definitions intentional? -- Joel Sherrill started a new discussion on bsps/powerpc/mvme2100/include/bsp.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159183 > +#define MVME_HAS_DEC21140 > + > +#define BSP_CONSOLE_PORT BSP_UART_COM1 This block of code is for the legacy stack. Do we have a way to move these to the legacy stack? -- Joel Sherrill started a new discussion on bsps/powerpc/mvme2100/include/bsp.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159184 > +char *save_boot_params(void *r3, void *r4, void *r5, char *cmdline_start, > + char *cmdline_end); > +void zero_bss(void); Again can this and other definitions/prototypes be moved to a less public place? -- Joel Sherrill started a new discussion on bsps/powerpc/mvme2100/start/bspstart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159185 > + */ > +unsigned int BSP_bus_frequency = BSP_VPD_NOT_FOUND; > +/* Add blank line above. -- Joel Sherrill started a new discussion on bsps/powerpc/mvme2100/start/bspstart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159186 > + */ > +unsigned int BSP_processor_frequency = BSP_VPD_NOT_FOUND; > +/* Add blank line above. -- Joel Sherrill started a new discussion on bsps/powerpc/mvme2100/start/motorola.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159187 > + > +/* > +** Board-specific table that maps interrupt names to onboard PCI ** to * -- Joel Sherrill started a new discussion on bsps/powerpc/mvme5100/include/bsp/irq.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159188 > + * CAUTION : BSP_PCI_IRQ_LOWEST_OFFSET should be equal to OPENPIC_VEC_SOURCE > + */ > +#ifndef qemu Can this BSP run on qemu? Did we lose the qemu prep BSP? -- Joel Sherrill started a new discussion on bsps/powerpc/mvme5100/include/bsp/irq.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159189 > + */ > +int BSP_irq_disable_at_i8259s(const rtems_irq_number irqLine); > +/* blank line above. -- Joel Sherrill started a new discussion on bsps/powerpc/mvme5100/include/bsp/irq.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159190 > + */ > +int BSP_irq_enable_at_i8259s(const rtems_irq_number irqLine); > +/* blank line above. -- Joel Sherrill started a new discussion on bsps/powerpc/mvme5100/include/bsp/irq.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159191 > + */ > +int BSP_irq_ack_at_i8259s(const rtems_irq_number irqLine); > +/* blank line above. -- Joel Sherrill started a new discussion on bsps/powerpc/mvme5100/start/bspstart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159192 > + */ > + ppc_interrupt_set_disable_mask(PPC_INTERRUPT_DISABLE_MASK_DEFAULT); > + Delete blank line. -- Joel Sherrill started a new discussion on bsps/powerpc/mvme5100/start/motorola.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482#note_159193 > + > +/* > +** Board-specific table that maps interrupt names to onboard PCI ** to * -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1482 You're receiving this email because of your account on gitlab.rtems.org. Unsubscribe from this thread: https://gitlab.rtems.org/-/namespace/49/sent_notifications/5-3jc4r4j6vl6zhu3pr3gaj7pmn-1d/unsubscribe | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | Help: https://gitlab.rtems.org/help
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
