Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1518 
was reviewed by Christian Mauderer

--
  
Christian Mauderer started a new discussion on 
bsps/arm/stm32f4/console/console-config.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1518#note_160400

 > -BSP_polling_getchar_function_type BSP_poll_char = NULL;
 > +RTEMS_SYSINIT_ITEM(
 > +  stm32f4_output_char_init,

Why do you need that in a sysinit item? The first time a character is printed, 
the stm32f4_output_char_init_early is called and that will do the 
initialization.

--
  
Christian Mauderer started a new discussion on 
spec/build/bsps/arm/stm32f4/optenusart3.yml: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1518#note_160401

 >  - enabled-by: true
 > -  value: true
 > +  value: false

If you disable this, no console will be enabled by default. You mentioned that 
you "Added PORT_COUNT \> 0 guards in case no USART is configured in 
config.ini.". Does that mean, the BSP doesn't compile in the default 
configuration anymore?

I think it's sensible to enable one UART that is commonly used on evaluation 
boards for that chip.


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1518
You're receiving this email because of your account on gitlab.rtems.org. 
Unsubscribe from this thread: 
https://gitlab.rtems.org/-/namespace/49/sent_notifications/5-9iex5h74ipeadq9p3egw5ue2g-1d/unsubscribe
 | Manage all notifications: https://gitlab.rtems.org/-/profile/notifications | 
Help: https://gitlab.rtems.org/help


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to