On May 3, 2011, at 2:08 PM, Dmitry Samersoff wrote: > Generally I agree that gamma launcher should be in hotspot test but minimal > "smoke" test at the end of the build is quite useful. The build system not > always handle correctly incremental build and Queens test usually catch it at > the earliest possible point. > > So I would like to: > > a) make gamma test JDK independent > b) move it to hotspot/test > c) keep it as part of build process > > -Dmitry
I have a hard time with c) but I understand you want some heartbeat test or indication the hotspot build is sane. But when that 'smoke' test starts impacting everyone else, then it needs to be isolated out of the default build. I know that having tests (heartbeat and smoke) run during the build is a somewhat common practice, but it really needs to go. And Queens is a fine little test, but it's really not enough. I would like to see a 'cd hotspot/make && make && make test' where the 'test' target runs your Queens test and maybe even a few other quick tests that the developers find helpful. Let the default 'make' be just a build, and running tests is a trivial 'make test'. I'd like to make that a general rule: #1 Do not run tests as part of the build process :^) -kto
