On 2013-06-24 20:45, Tim Bell wrote:
Erik:
Open part of this review:
There is an artificial limitation put into configure that prevents
usage of options --with-devkit and --with-tools-dir at the same time.
The reason was probably because they could potentially be
conflicting. This patch removes this check and makes them work
together, both ending up on the search path for tools (with
--with-tools-dir ending up ahead of devkit).
I also stumbled on some dead code that was causing warnings to be
printed when using --with-devkit and decided to remove that while
touching that option anyway.
http://cr.openjdk.java.net/~erikj/8017047/webrev.root.01/
In the new basics.m4:
362 TOOLS_DIR=$TOOLS_DIR:$with_devkit/bin
If TOOLS_DIR was empty, this will add an extra :
Probably harmless, but I'd prefer not to see it happen. If you feel
it is harmless, go ahead.
Code deletion looks good.
Yes, there would be an extra :, but it didn't seem to matter. We should
try to keep things correct though, so I added a convenience macro for
appending to a path without adding : if it's empty.
http://cr.openjdk.java.net/~erikj/8017047/webrev.root.02/
I also added calls to BASIC_FIXUP_PATH to make the parameters accept
relative paths.
/Erik
