Hi Erik:

In the new basics.m4:

362     TOOLS_DIR=$TOOLS_DIR:$with_devkit/bin

If TOOLS_DIR was empty, this will add an extra :

Probably harmless, but I'd prefer not to see it happen. If you feel it is harmless, go ahead.

Code deletion looks good.

Yes, there would be an extra :, but it didn't seem to matter. We should try to keep things correct though, so I added a convenience macro for appending to a path without adding : if it's empty.

http://cr.openjdk.java.net/~erikj/8017047/webrev.root.02/

I also added calls to BASIC_FIXUP_PATH to make the parameters accept relative paths.

/Erik

Yes, this is better.  Looks good.  Thanks.

Tim

Reply via email to