Hi Dave,
On 19/11/2013 1:34 AM, Dave Pointon wrote:
Hi again all ,
Having encountered the above defect and implemented a/the solution, I
would appreciate your feedback &/or comment.
Thanks to Neil Richards, the exploded webrev can be found at
http://cr.openjdk.java.net/~ngmr/JI-9008287/webrev.01/
Note that, if it isn't already obvious, the defect has been accepted but
has yet to be triaged, hence the JI number.
Minor style nit but note that the pattern used everywhere is x$FOO = x.
So changing to use "j" or "r" is undesirable.
MOre generally this seems solvable simply by changing the existing error
message to "an executable binary file for XXXX could not be found" - and
the user could see if it was missing or just not marked executable. :)
Re-use of the BOOTJDK_CHECK_TOOL_IN_BOOTJDK macro seems reasonable but I
don't think you really need to include the _WITH_OPT_ABORT in the name.
I'm sure Magnus will have more comments.
Cheers,
David H.
TIA & rgds ,
