Hi again, Magnus , On Fri, 2013-11-22 at 00:35 +1000, David Holmes wrote: > On 21/11/2013 11:05 PM, Magnus Ihse Bursie wrote: > > On 2013-11-19 13:47, Dave Pointon wrote: > >> The updated webrev can be found at > >> http://cr.openjdk.java.net/~ngmr/JI-9008287/webrev.02/ > > > > The actual code looks better, but I'm not so sure about the copyright > > header. The actual change was indeed very small, and is more or less a > > variation of what I suggested earlier. > > > > If you insist on keeping it, I'll need to check with legal support > > first. Otherwise I think it looks good (but I'm not a formal reviewer). > > That is my position as a Reviewer as well. > > Meanwhile we should see about migrating the bug from JI to JDK. > > Thanks, > David > > > /Magnus >
I've just received an update WRT the copyright change - it seems that I was inadvertently over zealous in the application of instructions and given the (lack of the) magnitude of the change, I should not have included the copyright statement. Would you like me to generate and indeed post, a new webrev ? Rgds , -- Dave Pointon FIAP MBCS Now I saw, tho' too late, the folly of beginning a work before we count the cost and before we we judge rightly of our strength to go thro' with it - Robinson Crusoe
