Hi Erik, Good work!
Some comment: * In JavaCompilation.gmk: add_files_to_copy_and_clean should be named only "..to_clean", otherwise it sounds as it is handling the copy part too. This was bad even before your fix, but then nobody really used that code. Could you please fix that? I have a hard time figuring out that sed expression, including your additions. Do you mind trying to document its intentions? * In CompileCorba.gmk; The removed JAR line looks weird. Is it an webrev artifact or was it dangling like that in the original makefile? How in the world come make didn't complain about it? The copy of zh_XX is done in GensrcCorba, but the original file is created in CompileCorba. Does that really work? On a clean compile? Looks incorrect to me. * In CopyIntoClasses: Is there a reason the swingbeaninfo gif files are not stored in the corresponding source directory? (I have a vague feeling this one been up before for discussion...) I'm not clear about the handling of zh_XX files here. First, you have an install-file %-pattern rule. Then you have an COPY_EXTRA addition. Are both needed? Why? Is it to create dependencies on the copied files? Is COPY_EXTRA really ALSO_DEPEND_ON_THESE_TARGETS? Have you confirmed that the CLEAN_FILES list does not intersect with the properties files listed for compilation? * In GensrcProperties: There was a comment on us not handling removed properties correctly in incremental builds. That's still applicable, right? The zh_XX code (again): there are two pattern rules with the same target. Do we alternatively copy generated and pre-generated files from src/share/classes? What if they clash? (I'm no good at how make resolved pattern rules.) If the zh_TW file is checked in and not generated, shouldn't we check in a copy as the zh_HK file as well? In convert_tw_to_hk, what kind of sed expression is that? Never seen one of those; what does it do? /Magnus 4 mar 2014 kl. 16:49 skrev Erik Joelsson <erik.joels...@oracle.com>: > Hello, > > Here is a rather big patch that mainly cleans up build logic for properties > files and other java resources. For a complete list of what was done, please > see the bug. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8036611 > > Webrev: http://cr.openjdk.java.net/~erikj/8036611/webrev.01/ > > /Erik >
