On 8/05/2014 5:56 PM, Erik Joelsson wrote:
Hello Dave,
Adding this information certainly makes sense. While probably not a very
common usecase, it is currently possible to point
"--with-import-hotspot" to the dist directory of a Hotspot build. The
problem then is that there will be no java launcher present to query for
version information. Could you please add a condition on the existance
of $with_import_hotspot/bin/java before trying to run it? If it's not
there, the version will simply be unknown.
This also needs to account for cross-compilation builds. You can't
execute the imported java then either.
Overall I'm not sure this change carries its weight. If you point
configure to a particular imported component, why should you expect
configure to tell you about the component you picked?
David H.
--------
The patch looks like it's missing indentation. This might be because of
formatting in JIRA, but in case it's not, please indent the if
statements properly with 2 spaces.
/Erik
On 2014-05-07 18:27, Dave Pointon wrote:
Hi ,
Although having to resort to the use of a different e-mail address,
JIC the
sig doesn't give it away :-), I'm back on the trail of adapting the OJDK
build to selectively use the IBM JVM together with modifying the IBM
build
to better incorporate the autoconf based approach in a manner that will
prove beneficial to all.
I now crave your indulgence for consideration of what I believe to be a
self-contained & thus no webrev, enhancement to the build system as
completely identified in
https://bugs.openjdk.java.net/browse/JDK-8037953...
TIA and rgds to all,
--
Dave Pointon FIAP MBCS
Now I saw, tho' too late, the folly of beginning a work before we
count the
cost and before we we judge rightly of our strength to go thro' with it -
Robinson Crusoe
