Hi Erik ,

On 12/05/14 09:35, Erik Joelsson wrote:
Hello Dave,

This looks better. However, the test for cross compilation is bit too restrictive. We have a variable called COMPILE_TYPE which can have the values "native", "reduced" and "cross". Reduced means that we compile for 32bit on an architecture that normally supports 64bit, and achieved with the --with-target-bits=32 flag. With the current test the hotspot version is not printed when a "reduced" compile is configured. I would suggest testing for COMPILE_TYPE != cross.

/Erik

Thanx for that, I did play with a test of "x$COMPILE_TYPE" = "xnative", but obviously the semantics of the values weren't quite as clear as I thought.


On 2014-05-09 14:49, pointo1d wrote:
Further to my previous e-mail, pls be advised that the webrev is now up on openjdk at http://cr.openjdk.java.net/~ngmr/8037953/webrev.00.

Rgds ,



Thanx again ,

--
​Dave Pointon FIAP MBCS

Now I saw, tho' too late, the folly of beginning a work before we count the 
cost and before we we judge rightly of our strength to go thro' with it - 
Robinson Crusoe

Reply via email to