On May 9 2014, at 03:54 , pointo1d <point...@gmail.com> wrote:
> Hi Mike ,
>
> On 09/05/14 03:19, Mike Duigou wrote:
>> Hello all;
>>
>> This issue is a follow-on bug fix to JDK-8041151 (Improve hgforest.sh
>> concurrency). That changeset introduced use of fifos for monitoring
>> sub-shell completion and included an alternative implementation for
>> configurations which did not properly support fifos. This changeset detects
>> another unsupported configuration, older shells which run the "read" command
>> using a sub-shell.
>>
>> I've tested the change on Solaris 10u11, Solaris 11u1, Ubuntu Linux 13.10
>> x64, MacOS 10.9. Of these only the Bash 3.2 shell on Solaris 10u11 does not
>> support FIFOs. I have not tested this specific change on Cygwin as FIFOs
>> were already disabled on Cygwin.
>
> Is either your test harness or your test cases available for general
> consumption in order that I might try them out and thus test and I trust
> confirm, the fix, on AIX (and indeed z/OS) please ?
I have neither a formal test harness or test suite. I have been doing all
testing manually across all platforms. And this issue demonstrates that there
have been gaps in the methodology and coverage.
If you have have patches for either of those platforms I would be happy to
incorporate them! (Most likely is lack of proper fifo support based upon shell
version).
I can outline what I do test though.
I test on the following:
Ubuntu linux 13.10 x64 with default bash and dash, ash
Cygwin ("recent update") x64 with default bash
MacOS X Mavericks x64 with macports bash (4.3) and when I remember default bash
Solaris 11.1 with default bash and ksh93 (/bin/sh is /bin/ksk93)
and following this issue I will be also adding testing with Solaris 10u10 or
later using it's default bash and ksh93
I usually do development on whichever platform is exhibiting problems. :-) The
extra coverage on linux is not because I expect that those shells will be used
but because it is convenient and quick to test several likely shells there.
For test commands I use a mix of local and remote commands:
status
summary
qpop -a
update
update -C
incoming
outgoing
pull -u
clone
serve (which I then test from another instance)
I try at least one local and one remote command with the -s option. I run my in
a test forest where I can delete sub-repos with impunity.
For some testing I had to hack the script to disable fifos. I have improved
upon this in the most recent revision by adding support for overriding defaults
via environment variables. (see separate notice for webrev update)
Mike
>
>> https://bugs.openjdk.java.net/browse/JDK-8042810
>> http://cr.openjdk.java.net/~mduigou/JDK-8042810/0/webrev/
>>
>> Mike
>
> TIA & best rgds ,
>
> --
> Dave Pointon FIAP MBCS
>
> Now I saw, tho' too late, the folly of beginning a work before we count the
> cost and before we we judge rightly of our strength to go thro' with it -
> Robinson Crusoe
>
