Looks good to me Mike. Nice work!
/Erik
On 2014-05-13 01:53, Mike Duigou wrote:
Hello all;
I have updated the webrev after additional testing and cleanup. I found a
couple of additional minor problems and added a feature that had been
requested. Some of the default behaviour can now be controlled using
environment variables. It had been pointed out that being able to run commands
as HGFOREST_SEQUENTIAL=true sh get_source.sh would have provided a good work
around on broken platforms. I ended up adding a lot of source comments since
testing took a while. Maybe someone will find the environment variables useful.
I also cleaned up a number of "buglets" and bashisms such as referencing undefined
variables, previously failing to report result code of root repo and use of $() in
"serve" command.
http://cr.openjdk.java.net/~mduigou/JDK-8042810/1/webrev/
Mike
On May 8 2014, at 19:19 , Mike Duigou <mike.dui...@oracle.com> wrote:
Hello all;
This issue is a follow-on bug fix to JDK-8041151 (Improve hgforest.sh concurrency). That
changeset introduced use of fifos for monitoring sub-shell completion and included an
alternative implementation for configurations which did not properly support fifos. This
changeset detects another unsupported configuration, older shells which run the
"read" command using a sub-shell.
I've tested the change on Solaris 10u11, Solaris 11u1, Ubuntu Linux 13.10 x64,
MacOS 10.9. Of these only the Bash 3.2 shell on Solaris 10u11 does not support
FIFOs. I have not tested this specific change on Cygwin as FIFOs were already
disabled on Cygwin.
https://bugs.openjdk.java.net/browse/JDK-8042810
http://cr.openjdk.java.net/~mduigou/JDK-8042810/0/webrev/
Mike
